Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config cleanup #1165

Merged
merged 13 commits into from
Dec 28, 2023
Merged

Config cleanup #1165

merged 13 commits into from
Dec 28, 2023

Conversation

joshk
Copy link
Collaborator

@joshk joshk commented Dec 24, 2023 •
edited
Loading

This supersedes #1137

  • Removes unused env files
  • Adds basic docs to config files
  • Removes unused config items
  • Reorder some config items for clarity
  • allow for inet_dist_listen_min and inet_dist_listen_max config to be opt out

jjcarstens
jjcarstens reviewed Dec 27, 2023
View reviewed changes
config/test.exs Outdated Show resolved Hide resolved
config/prod.exs Outdated Show resolved Hide resolved
config/runtime.exs Show resolved Hide resolved
@joshk
add ssl and pool_size back as env var configs
541317a 
the database `url` will take precedence
@joshk
switch back to some old sync_nodes_optional logic
8f01c1c 
I'll split this into its own PR soonn
jjcarstens
jjcarstens approved these changes Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@jjcarstens jjcarstens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After chatting a bit we decided to move the inet_dist_listen_* changes to their own PR as it was the only behavior being altered. The rest is reorganization and cleanup

@jjcarstens jjcarstens merged commit e3c3491 into main Dec 28, 2023
2 checks passed
@jjcarstens jjcarstens deleted the config-cleanup branch December 28, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjcarstens jjcarstens jjcarstens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshk @jjcarstens